Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitbucket - use non deprecated methods to get pull requests #233

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

koenigle
Copy link
Member

No description provided.

Copy link
Member

@christiansiegel christiansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, is this not working right now? Looks like this was silently broken in d719e43 because they deprecated the method in v1.15.1 by removing the implementation but keeping the method stub:
https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/bitbucket/__init__.py#L1749
Funky 🙊

Please merge with commit message in format fix(bitbucket): Fix PR integration to trigger a new minor release if this is actually a fix.

@joachimprinzbach
Copy link
Member

Woops, is this not working right now? Looks like this was silently broken in d719e43 because they deprecated the method in v1.15.1 by removing the implementation but keeping the method stub: https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/bitbucket/__init__.py#L1749 Funky 🙊

Yes, was not working. Error was:

07:47:07    File "/app/.venv/lib/python3.11/site-packages/gitopscli/git_api/bitbucket_git_repo_api_adapter.py", line 129, in get_pull_request_branch
07:47:07      if "errors" in pull_request:
07:47:07         ^^^^^^^^^^^^^^^^^^^^^^^^
07:47:07  TypeError: argument of type 'NoneType' is not iterable

https://github.com/baloise/gitopscli/blob/master/gitopscli/git_api/bitbucket_git_repo_api_adapter.py#L129

@christiansiegel christiansiegel merged commit 769830b into master Jul 17, 2024
2 checks passed
@christiansiegel christiansiegel deleted the getPullRequestsDeprecation branch July 17, 2024 04:45
Copy link

🎉 This issue has been resolved in version 5.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants