Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Github-Actions #32

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Adding Github-Actions #32

merged 3 commits into from
Jul 10, 2020

Conversation

arburk
Copy link
Contributor

@arburk arburk commented Mar 25, 2020

@arburk arburk requested a review from seejaybee as a code owner March 25, 2020 18:53
@arburk arburk changed the title created ci.yml Adding Github-Actions Mar 25, 2020
MarkusTiede
MarkusTiede requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@MarkusTiede MarkusTiede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this: can you please also add the removal of the circle-ci and travis builds and configurations? IMHO by using GH actions and mirroring this within our nexus AR those will no longer be necessary.

@arburk arburk requested a review from MarkusTiede March 26, 2020 16:28
@arburk
Copy link
Contributor Author

arburk commented Apr 28, 2020

Thanks for contributing this: can you please also add the removal of the circle-ci and travis builds and configurations? IMHO by using GH actions and mirroring this within our nexus AR those will no longer be necessary.

Hi Markus, the scripts are removed. Are there any further configurations to be adjusted on circleci or travis platform?

@MarkusTiede
Copy link
Member

We've (@arburk and I) manually disabled all webhooks pointing to travis & circle-ci - those should also no longer be used / triggered.

MarkusTiede
MarkusTiede approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@MarkusTiede MarkusTiede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this looks good - thanks a lot for contributing this change!

@MarkusTiede MarkusTiede mentioned this pull request May 7, 2020
Open
@seejaybee seejaybee merged commit b195cb1 into master Jul 10, 2020
@seejaybee seejaybee deleted the issue19_githubActions branch July 10, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusTiede MarkusTiede MarkusTiede approved these changes

@bsolar17 bsolar17 Awaiting requested review from bsolar17 bsolar17 is a code owner

@seejaybee seejaybee Awaiting requested review from seejaybee seejaybee is a code owner

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arburk @MarkusTiede @seejaybee