You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed a couple of things that might be improved in the project.
First, I see that when using DNSSD mode on Android, services always resolve with a single IP address which might be not enough sometimes. After a brief investigation (I am no Java expert) I saw that in android/src/main/java/com/balthazargronon/RCTZeroconf/rx2dnssd/DnssdImpl.java file the IP addresses are retrieved with the help of a deprecated getInet4Address method (line 87). Replacing it with by getInetAddresses allows to get multiple addresses — IPv4 as well as IPv6. At least that what happens when running the app on iOS.
I could make a PR myself, but I can't find a way to push the code as I seem not to have a permission to do that.
The second thing I wanted to propose is to update the Readme, because it is not obvious now that a user can switch between default NSD and additional DNSSD modes. I took me a day to figure out that this option existed at all.
The text was updated successfully, but these errors were encountered:
Hi,
I noticed a couple of things that might be improved in the project.
First, I see that when using DNSSD mode on Android, services always resolve with a single IP address which might be not enough sometimes. After a brief investigation (I am no Java expert) I saw that in android/src/main/java/com/balthazargronon/RCTZeroconf/rx2dnssd/DnssdImpl.java file the IP addresses are retrieved with the help of a deprecated getInet4Address method (line 87). Replacing it with by getInetAddresses allows to get multiple addresses — IPv4 as well as IPv6. At least that what happens when running the app on iOS.
I could make a PR myself, but I can't find a way to push the code as I seem not to have a permission to do that.
The second thing I wanted to propose is to update the Readme, because it is not obvious now that a user can switch between default NSD and additional DNSSD modes. I took me a day to figure out that this option existed at all.
The text was updated successfully, but these errors were encountered: