Merge pull request #18 from bancolombia/fix/dart-rules

- Remove angular rule definition
- Rename common rules to dart rules
- Change redirect from localhost to dcl.apps.bancolombia.com

CHANGELOG.md

@@ -1,4 +1,6 @@
 # Changelog
+## 1.1.1
+- Rename common rules to dart rules
 ## 1.1.0
 - Added new presets
 - Removed Angular framework rules

lib/src/analyzers/lint_analyzer/anti_patterns/pattern_utils.dart

@@ -21,10 +21,9 @@ Issue createIssue({
 /// Returns a url of a page containing documentation associated with [pattern]
 Uri documentation(Pattern pattern) => Uri(
       scheme: 'https',
-      host: 'localhost',
+      host: 'dcl.apps.bancolombia.com',
       pathSegments: [
         'docs',
-        'individuals',
         'anti-patterns',
         pattern.id,
       ],

lib/src/analyzers/lint_analyzer/lint_analysis_options_validator.dart

@@ -118,7 +118,8 @@ class LintAnalysisOptionsValidator {
             severity: Severity.warning,
             message:
                 "'${rule.ruleName}' is not recognized as a valid rule name.",
-            documentation: Uri.parse('https://localhost/rules'),
+            documentation:
+                Uri.parse('https://dcl.apps.bancolombia.com/docs/rules'),
             location: _copySpanWithOffset(rule.span),
           ),
         );
@@ -132,7 +133,8 @@ class LintAnalysisOptionsValidator {
             severity: Severity.warning,
             message:
                 "'${rule.ruleName}' requires a config to produce any diagnostics.",
-            documentation: Uri.parse('https://localhost/rules'),
+            documentation:
+                Uri.parse('https://dcl.apps.bancolombia.com/docs/rules'),
             location: _copySpanWithOffset(rule.span),
           ),
         );

lib/src/analyzers/lint_analyzer/metrics/metric_utils.dart

@@ -3,10 +3,9 @@ import 'models/metric_value_level.dart';
 /// Returns the url of a page containing documentation associated with [metricId]
 Uri documentation(String metricId) => Uri(
       scheme: 'https',
-      host: 'localhost',
+      host: 'dcl.apps.bancolombia.com',
       pathSegments: [
         'docs',
-        'individuals',
         'metrics',
         metricId,
       ],

lib/src/analyzers/lint_analyzer/rules/models/common_rule.dart → lib/src/analyzers/lint_analyzer/rules/models/dart_rule.dart

@@ -2,13 +2,13 @@ import 'rule.dart';
 import 'rule_type.dart';
 
 /// Represents a base class for common rules.
-abstract class CommonRule extends Rule {
-  const CommonRule({
+abstract class DartRule extends Rule {
+  const DartRule({
     required super.id,
     required super.severity,
     required super.excludes,
     required super.includes,
   }) : super(
-          type: RuleType.common,
+          type: RuleType.dart,
         );
 }

lib/src/analyzers/lint_analyzer/rules/models/rule_type.dart

@@ -4,7 +4,7 @@ class RuleType {
 
   const RuleType._(this.value);
 
-  static const common = RuleType._('common');
+  static const dart = RuleType._('dart');
   static const flutter = RuleType._('flutter');
   static const intl = RuleType._('intl');
   static const angular = RuleType._('angular');

lib/src/analyzers/lint_analyzer/rules/rule_utils.dart

@@ -27,10 +27,9 @@ Issue createIssue({
 /// Returns a url of a page containing documentation associated with [rule]
 Uri documentation(Rule rule) => Uri(
       scheme: 'https',
-      host: 'localhost',
+      host: 'dcl.apps.bancolombia.com',
       pathSegments: [
         'docs',
-        'individuals',
         'rules',
         rule.type.value,
         rule.id,

lib/src/analyzers/lint_analyzer/rules/rules_list/arguments_ordering/arguments_ordering_rule.dart

@@ -11,13 +11,13 @@ import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/replacement.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'config_parser.dart';
 part 'visitor.dart';
 
-class ArgumentsOrderingRule extends CommonRule {
+class ArgumentsOrderingRule extends DartRule {
   static const String ruleId = 'arguments-ordering';
 
   static const _warningMessage =

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_banned_imports/avoid_banned_imports_rule.dart

@@ -8,13 +8,13 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'utils/config_parser.dart';
 part 'visitor.dart';
 
-class AvoidBannedImportsRule extends CommonRule {
+class AvoidBannedImportsRule extends DartRule {
   static const String ruleId = 'avoid-banned-imports';
 
   final List<_AvoidBannedImportsConfigEntry> _entries;

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_cascade_after_if_null/avoid_cascade_after_if_null_rule.dart

@@ -9,12 +9,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidCascadeAfterIfNullRule extends CommonRule {
+class AvoidCascadeAfterIfNullRule extends DartRule {
   static const String ruleId = 'avoid-cascade-after-if-null';
 
   static const _warning =

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_collection_methods_with_unrelated_types/avoid_collection_methods_with_unrelated_types_rule.dart

@@ -12,13 +12,13 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'config_parser.dart';
 part 'visitor.dart';
 
-class AvoidCollectionMethodsWithUnrelatedTypesRule extends CommonRule {
+class AvoidCollectionMethodsWithUnrelatedTypesRule extends DartRule {
   static const String ruleId = 'avoid-collection-methods-with-unrelated-types';
 
   static const _warning = 'Avoid collection methods with unrelated types.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_double_slash_imports/avoid_double_slash_imports_rule.dart

@@ -9,12 +9,12 @@ import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/replacement.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidDoubleSlashImportsRule extends CommonRule {
+class AvoidDoubleSlashImportsRule extends DartRule {
   static const String ruleId = 'avoid-double-slash-imports';
 
   static const _warning = 'Avoid double slash import/export directives.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_duplicate_exports/avoid_duplicate_exports_rule.dart

@@ -8,12 +8,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidDuplicateExportsRule extends CommonRule {
+class AvoidDuplicateExportsRule extends DartRule {
   static const ruleId = 'avoid-duplicate-exports';
   static const _issueMessage = 'Avoid declaring duplicate exports.';
 

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_dynamic/avoid_dynamic_rule.dart

@@ -8,12 +8,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidDynamicRule extends CommonRule {
+class AvoidDynamicRule extends DartRule {
   static const String ruleId = 'avoid-dynamic';
 
   static const _warning = 'Avoid using dynamic type.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_global_state/avoid_global_state_rule.dart

@@ -9,12 +9,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidGlobalStateRule extends CommonRule {
+class AvoidGlobalStateRule extends DartRule {
   static const String ruleId = 'avoid-global-state';
 
   static const _warning =

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values_rule.dart

@@ -10,12 +10,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidIgnoringReturnValuesRule extends CommonRule {
+class AvoidIgnoringReturnValuesRule extends DartRule {
   static const String ruleId = 'avoid-ignoring-return-values';
 
   static const _warning = 'Avoid ignoring return values.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_late_keyword/avoid_late_keyword_rule.dart

@@ -8,13 +8,13 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'config_parser.dart';
 part 'visitor.dart';
 
-class AvoidLateKeywordRule extends CommonRule {
+class AvoidLateKeywordRule extends DartRule {
   static const String ruleId = 'avoid-late-keyword';
 
   static const _warning = "Avoid using 'late' keyword.";

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_missing_enum_constant_in_map/avoid_missing_enum_constant_in_map_rule.dart

@@ -9,12 +9,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidMissingEnumConstantInMapRule extends CommonRule {
+class AvoidMissingEnumConstantInMapRule extends DartRule {
   static const String ruleId = 'avoid-missing-enum-constant-in-map';
 
   static const _warning = 'Missing map entry for';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions_rule.dart

@@ -8,13 +8,13 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'config_parser.dart';
 part 'visitor.dart';
 
-class AvoidNestedConditionalExpressionsRule extends CommonRule {
+class AvoidNestedConditionalExpressionsRule extends DartRule {
   static const String ruleId = 'avoid-nested-conditional-expressions';
 
   static const _warning = 'Avoid nested conditional expressions.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_non_ascii_symbols/avoid_non_ascii_symbols_rule.dart

@@ -8,12 +8,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidNonAsciiSymbolsRule extends CommonRule {
+class AvoidNonAsciiSymbolsRule extends DartRule {
   static const String ruleId = 'avoid-non-ascii-symbols';
 
   static const _warning = 'Avoid using non ascii symbols in string literals.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_non_null_assertion/avoid_non_null_assertion_rule.dart

@@ -10,12 +10,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidNonNullAssertionRule extends CommonRule {
+class AvoidNonNullAssertionRule extends DartRule {
   static const String ruleId = 'avoid-non-null-assertion';
 
   static const _warning = 'Avoid using non null assertion.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_passing_async_when_sync_expected/avoid_passing_async_when_sync_expected_rule.dart

@@ -9,12 +9,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidPassingAsyncWhenSyncExpectedRule extends CommonRule {
+class AvoidPassingAsyncWhenSyncExpectedRule extends DartRule {
   static const String ruleId = 'avoid-passing-async-when-sync-expected';
 
   static const _warningMessage = 'Expected a sync function but got async.';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_redundant_async/avoid_redundant_async_rule.dart

@@ -10,12 +10,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidRedundantAsyncRule extends CommonRule {
+class AvoidRedundantAsyncRule extends DartRule {
   static const String ruleId = 'avoid-redundant-async';
 
   static const _warningMessage =

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_substring/avoid_substring_rule.dart

@@ -8,12 +8,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidSubstringRule extends CommonRule {
+class AvoidSubstringRule extends DartRule {
   static const String ruleId = 'avoid-substring';
 
   static const _warning =

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_throw_in_catch_block/avoid_throw_in_catch_block_rule.dart

@@ -8,12 +8,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidThrowInCatchBlockRule extends CommonRule {
+class AvoidThrowInCatchBlockRule extends DartRule {
   static const String ruleId = 'avoid-throw-in-catch-block';
 
   static const _warningMessage =

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_top_level_members_in_tests/avoid_top_level_members_in_tests_rule.dart

@@ -8,12 +8,12 @@ import '../../../lint_utils.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
-import '../../models/common_rule.dart';
+import '../../models/dart_rule.dart';
 import '../../rule_utils.dart';
 
 part 'visitor.dart';
 
-class AvoidTopLevelMembersInTestsRule extends CommonRule {
+class AvoidTopLevelMembersInTestsRule extends DartRule {
   static const String ruleId = 'avoid-top-level-members-in-tests';
 
   static const _warning = 'Avoid declaring top-level members in tests.';