Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Overwriting of flashloan_tokens List Set in main.py #35

Closed
mikewcasale opened this issue Jul 27, 2023 · 0 comments · Fixed by #43
Closed

Bug: Overwriting of flashloan_tokens List Set in main.py #35

mikewcasale opened this issue Jul 27, 2023 · 0 comments · Fixed by #43
Assignees
Labels
bug Something isn't working

Comments

@mikewcasale
Copy link
Contributor

The flashloan_tokens list, which is intended to be set via @click options in main.py, is currently being overwritten when bot.py is run. This issue disrupts the intended functionality and disregards the input provided by the user via the @click options.

Expected behavior

After setting the flashloan_tokens list in main.py using the @click options (with a string of token symbols separated by commas), the bot should respect this configuration and utilize these settings when it is run.

Actual behavior

Despite the correct setup of flashloan_tokens in main.py, the bot.py script overwrites this list. As a result, the user-defined input provided through the @click options isn't respected when running the bot.

Steps to reproduce

  1. In main.py, set the flashloan_tokens list using @click options.
  2. Run the bot.
  3. Observe that the bot run process overwrites the flashloan_tokens list and does not use the previously set values. This can be done by printing the flash loan tokens from within the bot.py functionality.

Proposed Resolution

A fix should be implemented in bot.py to prevent it from overwriting the flashloan_tokens list. Instead, bot.py should retrieve the list set by the user in main.py via the @click options. This approach would respect user's input and enhance the functionality of the bot script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant