Skip to content

Commit

Permalink
Fix #221 - Provide default dimensions for corner-case device sizes
Browse files Browse the repository at this point in the history
These prevent a crash on devices that don't fit into the other values-* folders
  • Loading branch information
barbeau committed Oct 8, 2018
1 parent dd8d3fc commit bbc8c3e
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions GPSTest/src/main/res/values/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,12 @@

<dimen name="sky_legend_shape_size">14dp</dimen>
<dimen name="sky_legend_shape_small_line">5dp</dimen>

<!-- Below values are only included as placeholders to satisfy #221 MissingDefaultResource
in the case where the other values folders for specific widths (values-w240dp, values-w400dp,
values-350dp, values-w350dp-v26) don't cover a specific device. In that case, if we don't
include the below defaults it would cause a crash. To edit these values on the vast majority
of devices, see the other values-* folders. -->
<dimen name="min_column_width">42dp</dimen>
<dimen name="status_text_size">13sp</dimen>
</resources>

0 comments on commit bbc8c3e

Please sign in to comment.