Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cobol textmate language and configuration. #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kathma0905
Copy link

@kathma0905 kathma0905 commented Jun 6, 2023

One IBM i language that is not covered is the COBOL language, this PR contributes COBOL language id, language configuration, and TextMate grammar.

Copy link
Collaborator

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
configurations/cobol.language-configuration.json Outdated Show resolved Hide resolved
@chrjorgensen chrjorgensen self-requested a review June 6, 2023 19:40
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathma0905 Nice addition to the IBM i languages! 👍

Please provide some COBOL sources in the tests/general directory to show your grammar in action when debugging this extension - like the other source examples. The COBOL sources should ideally cover all aspects (keywords, operation codes, identifiers etc) of COBOL to validate the grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants