Fix op-node-entrypoint #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
reviewed
Nov 7, 2023
| @@ -2,7 +2,7 @@ | |||
| set -eu | |||
|
|
|||
| # wait until local geth comes up (authed so will return 401 without token) | |||
| until [ "$(curl -s -w '%{http_code}' -o /dev/null "${OP_NODE_L2_ENGINE_RPC//ws/http}")" -eq 401 ]; do | |||
| until [ "$(curl -s -w '%{http_code}' -o /dev/null "${OP_NODE_L2_ENGINE_RPC}")" -eq 401 ]; do | |||
There was a problem hiding this comment.
${OP_NODE_L2_ENGINE_RPC//ws/http} is correct
what we are doing here is replacing the ws://geth:8551 with http://geth:8551, so that we can do a simple curl of the http endpoint rather than connecting to a ws endpoint
as mentioned in #143, ${OP_NODE_L2_ENGINE_RPC/ws/http} is probably more correct (removal of the first /), feel free to update to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#143