Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Return correct version information #204

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

danyalprout
Copy link
Collaborator

Description

Specify the version when building op-node, this

# Before
❯ curl -X POST -H "Content-Type: application/json" --data \
    '{"jsonrpc":"2.0","method":"optimism_version","params":[],"id":1}' \
    http://localhost:7545
{"jsonrpc":"2.0","id":1,"result":"v0.0.0-"}

# After
❯ curl -X POST -H "Content-Type: application/json" --data \
    '{"jsonrpc":"2.0","method":"optimism_version","params":[],"id":1}' \
    http://localhost:7545
{"jsonrpc":"2.0","id":1,"result":"v1.5.1-"}

@danyalprout danyalprout changed the title Setup base op-node to report accurate version tag fix(node): Return correct version information Feb 26, 2024
@danyalprout danyalprout merged commit 3b4eed9 into base-org:main Feb 26, 2024
4 checks passed
@danyalprout danyalprout deleted the accurate-version branch February 26, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants