Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nethermind #329

Merged
merged 48 commits into from
Oct 21, 2024
Merged

Add Nethermind #329

merged 48 commits into from
Oct 21, 2024

Conversation

stdevMac
Copy link
Contributor

Description

This pull request introduces support for the Nethermind Ethereum client on Base Chain.

The changes include:

  • updates to configuration files
  • Docker workflows
  • Addition of a new Dockerfile and entry point script for Nethermind.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 27, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

mdehoog
mdehoog previously approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@mdehoog mdehoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks! 🙌

mdehoog
mdehoog reviewed Sep 29, 2024
View reviewed changes
nethermind/Dockerfile Outdated Show resolved Hide resolved
benaadams and others added 2 commits September 29, 2024 03:14
@benaadams
Update commit
d03608d
@benaadams @mdehoog
Update nethermind/Dockerfile
1018327 
Co-authored-by: Michael de Hoog <michael.dehoog@gmail.com>
mdehoog
mdehoog reviewed Sep 29, 2024
View reviewed changes
nethermind/Dockerfile Outdated Show resolved Hide resolved
stdevMac and others added 15 commits October 2, 2024 19:02
@stdevMac
feat: add qemu to nethermind docker build
bbab781
@stdevMac
Merge pull request #1 from NethermindEth/feat/add_nethermind
d6a8829 
Feat/add nethermind
@stdevMac
fix: update release/1.29.0 commit
7188de1
@stdevMac
Merge pull request #2 from NethermindEth/feat/add_nethermind
0889f2b 
fix: update release/1.29.0 commit
@stdevMac
fix: build on nethermind
85c9f6b
@stdevMac
Merge pull request #3 from NethermindEth/feat/add_nethermind
a926e31 
fix: build on nethermind
@stdevMac
fix: build on nethermind, buildx command
5140551
@stdevMac
Merge pull request #4 from NethermindEth/feat/add_nethermind
642d542 
fix: build on nethermind, buildx command
@stdevMac
fix: build on nethermind, labels breaking buildx
f2feba6
@stdevMac
Merge pull request #5 from NethermindEth/feat/add_nethermind
70cc93e 
fix: build on nethermind, labels breaking buildx
@stdevMac
fix: build on nethermind, labels breaking buildx again
fa24cec
@stdevMac
Merge pull request #6 from NethermindEth/feat/add_nethermind
ce8149c 
fix: build on nethermind, labels breaking buildx again
@stdevMac
fix: build on nethermind, buildx
52f7c07
@stdevMac
Merge pull request #7 from NethermindEth/feat/add_nethermind
94c66df 
fix: build on nethermind, buildx
@stdevMac
fix: build on nethermind, buildx labels
4acf6e1
@benaadams
Copy link
Contributor

benaadams commented Oct 17, 2024 •
edited
Loading

Dropped arm64 as that looks like was causing build issues and updated tag version to latest release

@benaadams
Copy link
Contributor

Removed QEmu part of build

@cb-heimdall cb-heimdall dismissed mdehoog’s stale review October 20, 2024 08:46

Approved review 2335492946 from mdehoog is now dismissed due to new commit. Re-request for approval.

mdehoog
mdehoog reviewed Oct 20, 2024
View reviewed changes
.github/workflows/pr.yml Outdated Show resolved Hide resolved
@cb-heimdall
Copy link
Collaborator

Review Error for Nifitsas4 @ 2024-10-20 11:01:12 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

Review Error for Nifitsas4 @ 2024-10-20 11:02:37 UTC
User must have write permissions to review

@benaadams
Copy link
Contributor

Reth arm64 build ran out of memory, assume unrelated?

mdehoog
mdehoog approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mdehoog mdehoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👏 thanks!

@mdehoog mdehoog merged commit f038903 into base-org:main Oct 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams left review comments

@Nifitsas4 Nifitsas4 Nifitsas4 approved these changes

@mdehoog mdehoog mdehoog approved these changes

@danyalprout danyalprout Awaiting requested review from danyalprout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stdevMac @cb-heimdall @benaadams @mdehoog @Nifitsas4