Fix timezone issue #170
Merged
Fix timezone issue #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: changed schedule api to respect the time constants
chore: marked view more links as external to open in new tab
chore: seo optimizations
fix: spoof date from query param in getNow util
chore: using generate tweets instead of on the fly tweets fetch
…l build under my name
…-trigger-vercel-build chore: added github workflow to commit empty message to trigger build
Signed-off-by: Arpit Srivastava <arpit.srivastava@coinbase.com>
* chore: seo optimizations * chore: using generate tweets instead of on the fly tweets fetch * fix: build issue * chore: marked view more links as external to open in new tab * chore: changed schedule api to respect the time constants * fix: spoof date from query param in getNow util * fix: remove spoof date from getDateRangeValidation * docs: update readme file * chore: teaser page layout cleanup * chore: added github workflow to commit empty message to trigger Vercel build under my name * chore: testing with repo url * chore: testing with repo owner logic * chore: synced schedule dates * chore: update footer design + layout * feat: replace next-image with img to avoid caching issues * empty commit * feat: restructure validation logic to support zora and external, external unfinished * feat: show max per user mint in button message * feat: refactor to enable zora write tx * feat: allow zora native minting * fix: sync useValidate * feat: add zora test mint * feat: new crossmint id * fix: crossmint working with zora * empty commit * chore: add links to footer * chore: undo mobile nav styles * chore: implement new mobile nav design * fix: top margin for community Signed-off-by: Arpit Srivastava <arpit.srivastava@coinbase.com> * empty commit * fix: padding issue Signed-off-by: Arpit Srivastava <arpit.srivastava@coinbase.com> * empty commit * feat: remove console.log * fix: lint fixes on add-zora branch * feat: make address pill an external link * fix: schedule issue * empty commit * feat: replace next-image with img to avoid caching issues * feat: remove console.log * empty commit * empty commit * fix: schedule issue * feat: restructure validation logic to support zora and external, external unfinished * feat: show max per user mint in button message * feat: refactor to enable zora write tx * feat: allow zora native minting * fix: sync useValidate * feat: add zora test mint * feat: new crossmint id * fix: crossmint working with zora * empty commit * fix: lint fixes on add-zora branch * feat: add zora contract to test-contracts and add minttype * fix: fix base config for testnet * chore: update footer links * feat: typography styles * chore: add featured title community page * feat: custom typography responsive * chore: fix nav button sizing * feat: trending page layout * chore: changed mobile navbar globally * fix: banner icon to be used in past and upcoming both * chore: redirect to live stream from /live path * chore: added anirud-samala in git workflow * feat: mint analytics events * fix: undo change * fix: undo change from other repo * empty commit * chore: update tending page and component designs * empty commit * chore: fix trending page top spacing * chore: fix partnerhero position on home page * chore: remove empty space * feat: new images on community page, make clickable * empty commit * chore: fix PageContainer logic * empty commit * feat: use mintWithRewards for zora * feat: update zora test contracts * empty commit * chore: base banner image updated * chore: undo page container changes * fix: twitter module null error * chore: not writing to file if no data is returned * chore: silent failure * chore: partially updated schedule * chore: deleting file only when writing to it * feat: button using base text size and disabled state * chore: made tweet cards clickable * chore: updated schedule partners and base contract * empty commit * chore: work * chore: empty commit * chore: base config update * feat: add checking for home page, fix partnerhero placement * fix: add check for window obj * fix: catch user rejected request on mint dot fun mint * empty commit * chore: dummy arweave ID for testing * feat: navbar typography and layout fixes * chore: base day one config * empty commit * chore: change base day one to aug 9 * feat: page layout * chore: clamping to nearest work * chore: updated tweets file * feat: make mint.fun clickable * chore: added spacing and took away dollar sign from community grant section * empty commit * feat: mobile nav fixed * feat: not found typography * chore: added spacing between total and number * feat: partner hero typography * feat: restyle arweve component * feat: trending and drop card typographies * feat: trending and tabs typography * fix: add more spacing Signed-off-by: Arpit Srivastava <arpit.srivastava@coinbase.com> * empty commit * feat: community page typography * chore: add new icon for base * chore: updated community start and end dates * empty message * feat: add prop house Signed-off-by: Arpit Srivastava <arpit.srivastava@coinbase.com> * empty commit * empty commit * empty commit * fix: remove color from typography * chore: update arweave for base day one and partner descriptions * chore: add dev arweave for base day one * empty commit * feat: mobile nav layout shift fix * feat: mint dialog typography * feat: remove commented old layout * empty commit * chore: base day one completely separate * feat: use tailwind prose for article * chore: updated description of partners based on the execution tracker sheet * feat: line clamp on calendar card description * chore: changed contract address * chore: actioned column X of the tracker sheet * empty commit * empty commit * chore: actioned brand color and name for base day one * chore: changed * fix: wrap article fetching in try/catch --------- Signed-off-by: Arpit Srivastava <arpit.srivastava@coinbase.com> Co-authored-by: Azim Ahmed <azim.ahmed7@gmail.com> Co-authored-by: Djordje <djordje_v@hotmail.com> Co-authored-by: wilsoncusack <cusackw@gmail.com> Co-authored-by: Azim Ahmed <ximxim@users.noreply.github.com> Co-authored-by: Wilson Cusack <wilson.cusack@coinbase.com> Co-authored-by: Arpit Srivastava <arpit.srivastava@coinbase.com> Co-authored-by: Lukas Rosario <lukas@lsr.dev> Co-authored-by: AshishYelekar <ayelekar@gmail.com>
* Wilson/lazr sync (#145) * chore: seo optimizations * chore: using generate tweets instead of on the fly tweets fetch * fix: build issue * chore: marked view more links as external to open in new tab * chore: changed schedule api to respect the time constants * fix: spoof date from query param in getNow util * fix: remove spoof date from getDateRangeValidation * docs: update readme file --------- Co-authored-by: Azim Ahmed <azim.ahmed7@gmail.com> Co-authored-by: lauchness <lauchlanchisholm@gmail.com> Co-authored-by: Lauchlan Chisholm <51837850+lauchness@users.noreply.github.com> * Wilson/lazr sync (#145) * chore: seo optimizations * chore: using generate tweets instead of on the fly tweets fetch * fix: build issue * chore: marked view more links as external to open in new tab * chore: changed schedule api to respect the time constants * fix: spoof date from query param in getNow util * fix: remove spoof date from getDateRangeValidation * docs: update readme file --------- Co-authored-by: Azim Ahmed <azim.ahmed7@gmail.com> Co-authored-by: lauchness <lauchlanchisholm@gmail.com> Co-authored-by: Lauchlan Chisholm <51837850+lauchness@users.noreply.github.com> * chore: debugging * fix: revert docker file change, run tweets locally * fix: new tweets * Wilson/lazr sync (#145) * chore: seo optimizations * chore: using generate tweets instead of on the fly tweets fetch * fix: build issue * chore: marked view more links as external to open in new tab * chore: changed schedule api to respect the time constants * fix: spoof date from query param in getNow util * fix: remove spoof date from getDateRangeValidation * docs: update readme file --------- Co-authored-by: Azim Ahmed <azim.ahmed7@gmail.com> Co-authored-by: lauchness <lauchlanchisholm@gmail.com> Co-authored-by: Lauchlan Chisholm <51837850+lauchness@users.noreply.github.com> * fix: update tweets * chore: update tweets * Wilson/lazr sync (#145) * chore: seo optimizations * chore: using generate tweets instead of on the fly tweets fetch * fix: build issue * chore: marked view more links as external to open in new tab * chore: changed schedule api to respect the time constants * fix: spoof date from query param in getNow util * fix: remove spoof date from getDateRangeValidation * docs: update readme file --------- Co-authored-by: Azim Ahmed <azim.ahmed7@gmail.com> Co-authored-by: lauchness <lauchlanchisholm@gmail.com> Co-authored-by: Lauchlan Chisholm <51837850+lauchness@users.noreply.github.com> --------- Co-authored-by: Azim Ahmed <azim.ahmed7@gmail.com> Co-authored-by: lauchness <lauchlanchisholm@gmail.com> Co-authored-by: Lauchlan Chisholm <51837850+lauchness@users.noreply.github.com>
fix: mirror caching in file
feat: fix spacing in partner hero
…ption chore: update fwb description
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wilsoncusack
reviewed
Aug 9, 2023
| @@ -137,8 +138,7 @@ export async function generateMetadata( | |||
|
|
|||
| async function getPartner(slug: string, spoofDate?: string) { | |||
| const now = getNow(spoofDate) | |||
|
|
|||
| const today = format(now, 'yyyy-MM-dd') | |||
| const today = getDropDate(spoofDate) | |||
There was a problem hiding this comment.
@lauchness does this rely on spoofdate everywhere?
There was a problem hiding this comment.
It allows for spoof date, but relys on UTC time under the hood
wilsoncusack
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comparison for schedule was relying on local timezone - this PR ensures time comparisons use UTC only