Add provenance option #972
Open
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Sep 25, 2024
| @@ -97,6 +97,10 @@ def build_ssh | |||
| argumentize "--ssh", ssh if ssh.present? | |||
| end | |||
|
|
|||
| def builder_provenance | |||
| argumentize "--provenance", provenance unless provenance.nil? | |||
There was a problem hiding this comment.
Suggested change
| argumentize "--provenance", provenance unless provenance.nil? | |
| argumentize "--provenance", provenance if provenance.present? |
There was a problem hiding this comment.
This is intentional design, because if provenance is false, it should output the --provenance false option. It should only skip outputting --provenance … if provenance is nil.
|
See also #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
provenanceoption in thebuilderconfig. You can useprovenance: falseto prevent the showing ofunknown/unknownarchitecture on the container registry.Description
I am using Kamal with GitHub Container Registry, and it works very well. However, when I push images to the container registry, I noticed an
unknown/unknownarchitecture listed on the registry. See the screenshot below.I believe this is an issue with the UI of the registry service, such as GitHub Container Registry. You can use
provenance: falseas a workaround to avoid the issue.Once the PR is merged, you can use the following config to prevent pushing the
unknown/unknownarchitecture.Related information