Skip to content

Commit

Permalink
Fix review problems
Browse files Browse the repository at this point in the history
  • Loading branch information
slfritchie committed Aug 13, 2014
1 parent 404e80f commit 76e3ff2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
20 changes: 10 additions & 10 deletions priv/erlang_vm.schema
Original file line number Diff line number Diff line change
Expand Up @@ -221,18 +221,18 @@
{datatype, integer}
]}.

%% @doc Enable or disable scheduler compaction of load. By default sched-
%% uler compaction of load is enabled. When enabled, load balancing
%% will strive for a load distribution which causes as many sched-
%% uler threads as possible to be fully loaded (i.e., not run out of
%% work). This is accomplished by migrating load (e.g. runnable pro-
%% cesses) into a smaller set of schedulers when schedulers fre-
%% quently run out of work. When disabled, the frequency with which
%% schedulers run out of work will not be taken into account by the
%% @doc Enable or disable scheduler compaction of load. By default
%% scheduler compaction of load is enabled. When enabled, load
%% balancing will strive for a load distribution which causes as many
%% scheduler threads as possible to be fully loaded (i.e., not run out
%% of work). This is accomplished by migrating load (e.g. runnable
%% processes) into a smaller set of schedulers when schedulers
%% frequently run out of work. When disabled, the frequency with which
%% schedulers run out of work will not be taken into account by the
%% load balancing logic.
%%
%% More information: http://www.erlang.org/doc/man/erl.html#+scl
{mapping, "erlang.schedulers.scheduler_compaction_of_load", "vm_args.+scl", [
{mapping, "erlang.schedulers.compaction_of_load", "vm_args.+scl", [
{commented, "false"},
{datatype, {enum, [true, false]}}
]}.
Expand All @@ -247,7 +247,7 @@
%% strive for equal scheduler utilization on all schedulers.
%%
%% More information: http://www.erlang.org/doc/man/erl.html#+sub
{mapping, "erlang.schedulers.scheduler_utilization_balancing", "vm_args.+sub", [
{mapping, "erlang.schedulers.utilization_balancing", "vm_args.+sub", [
{commented, "true"},
{datatype, {enum, [true, false]}}
]}.
Expand Down
4 changes: 2 additions & 2 deletions test/erlang_vm_schema_tests.erl
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ override_schema_test() ->
{["erlang", "process_limit"], 128001},
{["erlang", "distribution_buffer_size"], 1024},
{["erlang", "schedulers", "force_wakeup_interval"], 500},
{["erlang", "schedulers", "scheduler_compaction_of_load"], true},
{["erlang", "schedulers", "scheduler_utilization_balancing"], false},
{["erlang", "schedulers", "compaction_of_load"], true},
{["erlang", "schedulers", "utilization_balancing"], false},
{["erlang", "distribution", "port_range", "minimum"], 6000},
{["erlang", "distribution", "port_range", "maximum"], 7999},
{["erlang", "distribution", "net_ticktime"], 43}
Expand Down

5 comments on commit 76e3ff2

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from seancribbs
at 76e3ff2

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/cuttlefish/bugfix/vm-args-scl-false-20 = 76e3ff2 into borshop-integration-163-bugfix/vm-args-scl-false-20

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/cuttlefish/bugfix/vm-args-scl-false-20 = 76e3ff2 merged ok, testing candidate = b2ce0b1

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding 2.0 to borshop-integration-163-bugfix/vm-args-scl-false-20 = b2ce0b1

Please sign in to comment.