Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing hmac deprecated functions #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joaovsq
Copy link

@joaovsq joaovsq commented Sep 21, 2020

No description provided.

Vagabond and others added 6 commits February 9, 2018 15:23
Just running make test will be sufficient, the property is run by ./rebar3 eqc and it fails on some machines
Update rebar and explain property failure
@paulo-ferraz-oliveira
Copy link

Is this lib. being maintained still? This PR is important, and I'd not like to have to fork it, if that's the case.

@joaovsq
Copy link
Author

joaovsq commented Oct 27, 2020

I'm not sure, but i had to create a fork https://github.com/code-time/erlang-pbkdf2

@dmsnell
Copy link

dmsnell commented Jan 1, 2021

Saw this only after submitting comtihon#1 where I added a compatibility layer to avoid breaking pre-R22 use.

@paulo-ferraz-oliveira
Copy link

:) We started our own fork here.

@gearnode
Copy link

@paulo-ferraz-oliveira If you don't want to maintain a fork, you can use our implementation.

@paulo-ferraz-oliveira
Copy link

@paulo-ferraz-oliveira If you don't want to maintain a fork, you can use our implementation.

Hm... I would, but it's not on Hex.pm, unfortunately.

@gearnode
Copy link

@paulo-ferraz-oliveira It's a blocker for you?

@paulo-ferraz-oliveira
Copy link

It's not a blocker to not have the stuff in Hex.pm... not really. But we really do prefer it as much as possible. I can't think of a single dep. we use (over more than 50+) that pulls from GitHub. The most obvious benefit being the local cache (so faster builds all around). I can understand you not wanting to put stuff there, though. No prob.

@gearnode
Copy link

@paulo-ferraz-oliveira The Erlang/OTP team merge my pull request to add pbkdf2 in the crypto module, so if you want, you don't need any more dependence for this :)

@paulo-ferraz-oliveira
Copy link

@paulo-ferraz-oliveira The Erlang/OTP team merge my pull request to add pbkdf2 in the crypto module, so if you want, you don't need any more dependence for this :)

Thanks for the heads up, @gearnode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants