-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing hmac deprecated functions #12
base: master
Are you sure you want to change the base?
Conversation
Just running make test will be sufficient, the property is run by ./rebar3 eqc and it fails on some machines
Update rebar and explain property failure
…into develop-3.0
Is this lib. being maintained still? This PR is important, and I'd not like to have to fork it, if that's the case. |
I'm not sure, but i had to create a fork https://github.com/code-time/erlang-pbkdf2 |
Saw this only after submitting comtihon#1 where I added a compatibility layer to avoid breaking pre-R22 use. |
:) We started our own fork here. |
@paulo-ferraz-oliveira If you don't want to maintain a fork, you can use our implementation. |
Hm... I would, but it's not on Hex.pm, unfortunately. |
@paulo-ferraz-oliveira It's a blocker for you? |
It's not a blocker to not have the stuff in Hex.pm... not really. But we really do prefer it as much as possible. I can't think of a single dep. we use (over more than 50+) that pulls from GitHub. The most obvious benefit being the local cache (so faster builds all around). I can understand you not wanting to put stuff there, though. No prob. |
Develop 3.0
@paulo-ferraz-oliveira The Erlang/OTP team merge my pull request to add |
Thanks for the heads up, @gearnode. |
No description provided.