Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to use OTP24 and Rebar3 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccapndave
Copy link

I upgraded this to use rebar3 and the new mac_* functions in OTP24. I don't know Erlang at all, only Elixir, but I was using this library and needed it to work with the latest Elixir and Erlang so I had a bash at it. It seems to work :)

@ThomasArts
Copy link

Hi @ccapndave
Bumped into this repository for a different reason and noted your PR. Good you took that on.

There is a special branch "develop-3.0" with tag 2.1.0 which already uses rebar3.
This is confusing, but for backward compatibility reasons (riak running on older Erlang versions) this cannot go into the master branch.

So the Mac changes on top of develop-3.0 branch makes more sense.
But check whether these functions support Erlang OTP 20 as well, otherwise you need to check on version and call the right one, depending on Erlang OTP version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants