Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger node confirms failure if clock expected #1858

Merged
merged 1 commit into from
May 12, 2023
Merged

Don't trigger node confirms failure if clock expected #1858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/riak_kv_get_core.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,15 @@ enough(_) ->
%% Get success/fail response once enough results received
-spec response(getcore()) -> {reply(), getcore()}.
%% Met quorum for a standard get request/response
response(#getcore{node_confirms = RequiredConfirms,
confirmed_nodes = Nodes} = GetCore)
when length(Nodes) < RequiredConfirms ->
check_overload({error,
{insufficient_nodes,
length(Nodes), need, RequiredConfirms}}, GetCore);
response(
#getcore{
node_confirms = RqdConfirms,
confirmed_nodes = Nodes,
expected_fetchclock = ExpClock} = GetCore)
when (length(Nodes) < RqdConfirms andalso ExpClock =/= true) ->
check_overload(
{error, {insufficient_nodes, length(Nodes), need, RqdConfirms}},
GetCore);
%% Insufficient nodes confirmed
response(#getcore{r = R, num_ok = NumOK, pr= PR, num_pok = NumPOK,
expected_fetchclock = ExpClock, head_merge = HM} = GetCore)
Expand Down