Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add tests for broadcasting #385

Merged
merged 8 commits into from
Oct 2, 2024
Merged

TST: Add tests for broadcasting #385

merged 8 commits into from
Oct 2, 2024

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Oct 2, 2024

No description provided.

return all([(arg is None or np.isscalar(arg)) for arg in args])


def get_broadcastable_size(a, b, c):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note test

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 98.29060% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.41%. Comparing base (883e85c) to head (a5dc355).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
randomgen/tests/_shims.pyx 95.45% 1 Missing ⚠️
randomgen/tests/test_broadcasting.py 98.76% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   93.70%   95.41%   +1.70%     
==========================================
  Files          55       56       +1     
  Lines        8489     8591     +102     
  Branches      551      578      +27     
==========================================
+ Hits         7955     8197     +242     
+ Misses        507      366     -141     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bashtage bashtage merged commit 6f1cc8d into main Oct 2, 2024
25 checks passed
@bashtage bashtage deleted the test-broadcast branch October 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant