Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with Wagtail 3.0 #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Siburg
Copy link

@Siburg Siburg commented Jun 4, 2023

Work In Progress PR to implement #17. Not yet intended for merging.

Work done:

  • Apply Wagtail 3.0 changes to module paths
  • Replace ImageChooserPanel with FieldPanel
  • Remove obsolete Wagtail SiteMiddleware references
  • Remove default_app_config for Django 3.2
  • Update requirements.txt and setting for example app
  • Update external links in base.html
  • Start updating README.rst and setup.cfg
  • Fix linter complaints

To do:

  • review testing and desired package compatability
  • update tox.ini
  • continue updating README.rst and setup.cfg
    Maybe other things as well that I have not thought of yet.

- Apply Wagtail 3.0 changes to module paths
- Replace ImageChooserPanel with FieldPanel
- Remove obsolete Wagtail SiteMiddleware references
- Remove default_app_config for Django 3.2
- Update requirements.txt and setting for example app
- Update external links in base.html
- Start updating README.rst and setup.cfg
- Fix linter complaints
@Siburg
Copy link
Author

Siburg commented Jun 4, 2023

@bashu here is initial, incomplete PR. Running tests locally with pytest is not working for me. Would welcome your views on how to proceed, or I would be happy for you to take it from here; if you wish.

Django == 3.2.*
wagtail == 4.1.*
django-meta >= 2.1.0 # https://github.com/nephila/django-meta
puput == 1.2.0 # https://github.com/APSL/puput
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider going to version 1.2.1. That adds support for Django 4 versions, but drops support for Python 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant