gige: set upper exposure also for current setting #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
auto_exposure_upper_limitis taken into account not only whenstartup_user_setis set toDefaultbut also when it is set toCurrentSetting.I am not sure what was the reason for not allowing changing
auto_exposure_upper_limitwhen usingCurrentSettingand I could not find a good reason for this from the pylon API documentation.I tested it with our cameras, where we need to use
CurrentSettingbut still setauto_exposure_upper_limit, and it works well.Note: I only changed the code for the
gigecamera type. I am not sure if this would also work for the other types.