Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#46 Fix regexp support for resource names #47

Merged
merged 2 commits into from
Jul 17, 2024
Merged

#46 Fix regexp support for resource names #47

merged 2 commits into from
Jul 17, 2024

Conversation

vincent-zurczak
Copy link
Member

Fix the behavior for resource names to match what was written in the README file.

@vincent-zurczak vincent-zurczak requested a review from a team July 15, 2024 16:07
@vincent-zurczak vincent-zurczak removed the request for review from a team July 16, 2024 15:39
@vincent-zurczak
Copy link
Member Author

vincent-zurczak commented Jul 16, 2024

Hello @brokenpip3.
Thank you for your review. However, the PR is still blocked as « approving review is required by reviewers with write access ». Was there a change recently?

Cc: @bats-core/bats-detik

@brokenpip3
Copy link

Probably I do not have anymore the write grants in this repo :)

@martin-schulze-vireso
Copy link
Member

Yes, the permissions granted by the homebrew team were initially too broad. If you want brokenpip3 as co-maintainer, we can add him to the bats-detik team.

lib/detik.bash Show resolved Hide resolved
@vincent-zurczak vincent-zurczak merged commit cc98de0 into master Jul 17, 2024
4 checks passed
@vincent-zurczak
Copy link
Member Author

If @brokenpip3 agrees, I see no objection to add him in the bats-detik team.

@brokenpip3
Copy link

If @brokenpip3 agrees, I see no objection to add him in the bats-detik team.

my pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants