loading content for each episode #762
Conversation
|
will work on better style for QuickStart, Resources by either using Section Cards just like home or modifying the DocumentationPage component |
…in tips page, possible improvements on the style of resources and QuickStart pages using HTML cards style just like Tournaments page
nour-massri
force-pushed
the
nour/loading_content_per_episode
branch
from
a2fab4e
to
f2e6e3b
Compare
| { path: "debuggingtips", element: <DebuggingTips /> }, | ||
| { path: "commonissues", element: <CommonIssues /> }, |
There was a problem hiding this comment.
nit: move these in between the team profile page and page not found
| CommonIssuesPageKey, | ||
| QuickStartedPageKey, | ||
| ResourcesPageKey, | ||
| TourneyPageKey, |
There was a problem hiding this comment.
Make sure to run npm run lint or npm run format to make sure any lint issues are fixed before committing (idk why these aren't thrown as errors by our CD pipeline though...)
| @@ -177,6 +180,8 @@ const router = createBrowserRouter([ | |||
| }, | |||
| ], | |||
| }, | |||
| { path: "debuggingtips", element: <DebuggingTips /> }, | |||
There was a problem hiding this comment.
nit: prefer hyphenation for multi-word url paths (i.e. debugging-tips)
| import { BC23_TOURNAMENTS } from "./bc23"; | ||
| import { BC22_TOURNAMENTS } from "./bc22"; | ||
|
|
||
| export const defaultQuickStartText = BC24_QUICKSTART; |
There was a problem hiding this comment.
I saw some issues with certain text fields showing "2024" even when we're on the 2022/23 version of this page (and, in general, mix-ups with years). I think defaulting content pages is, in general, not preferable. We should discuss this at this week's hack session and see if we can all come to an agreement on how we want to manage/handle duplicate content.
| import SectionCard from "../components/SectionCard"; | ||
| import { CommonIssuesPage } from "../content/ContentStruct"; | ||
|
|
||
| const DebuggingTips = (): JSX.Element => { |
There was a problem hiding this comment.
nit: prefer React.FC instead of JSX.Element here
| return ( | ||
| <div className="flex h-full w-full flex-col overflow-y-auto bg-white p-6"> | ||
| <div className="flex flex-1 flex-col gap-8"> | ||
| <SectionCard> |
There was a problem hiding this comment.
Would it be better to move the section title to the title prop of SectionCard instead of in the markdown? I think it could be.
|
|
||
| Battlecode 2022 will have several tournaments throughout the month! We stream and commentate all tournaments online. The deadline to submit code for each non-final tournament is usually 7 pm EST the day before the tournament. | ||
| `, | ||
| prizes: `# Prizes |
There was a problem hiding this comment.
Were these the prizes for BC22?
Modified src/content folder to add a content file for each episode
created ManageContent.ts to create records: <episode_id, text> for each content page: quickstart, resources and tournaments
created ContentStrucuts.ts to manage types used in Tournament record
Closes #785 🚀