-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove broken Go tutorial code and fix typo #73
base: gh-pages
Are you sure you want to change the base?
Conversation
@chrislovecnm look right to you? |
We need to fix this rather than delete the line, as it is needed. When you run gazelle first do you have any Build files? Otherwise we need to touch the missing file. |
I do have the same Deleting that line is fine. When |
This also mimics the workspace file in the official Gazelle Go tutorial |
@@ -424,7 +415,7 @@ and created new `BUILD.bazel` files as well. Here is a layout of the Bazel files | |||
└── BUILD.bazel | |||
``` | |||
|
|||
The `WORKSPACE` file was updated as well, and we have a new file called `deps.bzl`. | |||
The `WORKSPACE` file was updated as well, now loading the go dependecy definitions from a new file called `deps.bzl`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's typo in the new text: dependecy
should be dependency
I think I figured out the fix for it. You need a deps.bizl with a function in it I will submit a PR. |
I created #74 to fix the deps.bzl problem. @MattyKuzy what do you think? |
s/bazelist/bazelisk/g
Also, the line to load the
deps.bzl
doesn't work if you're trying to follow the tutorial. That file has not been generated yet so any Bazel commands break when theWORKSPACE
tries to load it. That code will be generated bybazel run //:gazelle-update-repos