-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Add support for runtime_toolchain_type for jq/yq/... #747
Comments
We didn't intend to provide jq or yq for the target platform, and from this issue I don't understand why that would be useful. the rules_oci |
jq/yq is used at runtime (target) while the binary is for build time (exec). For example, you can think bout how java works if you compile on Linux for Linux with Windows executors. When we run the build results, it should not use java.exe. |
Eg: using jq/yq in executable rules (ie: bazel tests or bazel run scripts) |
#875 partially implements this feature. |
What is the current behavior?
No response
Describe the feature
The current toolchain only provides the binary for use during the build but no binary for the build output. People already misuse the cfg=exec binary in a cfg=target output, e.g. https://github.com/bazel-contrib/rules_oci/blob/main/oci/private/push.sh.tpl. Providing another runtime_toolchain_type (similar to what rules_java does) can help improve the current situation. Alternatively, we can provide both exec and target binary in the current toolchain and ask users to use the correct binary.
The text was updated successfully, but these errors were encountered: