Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub repository to sidebar #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hobofan
Copy link
Member

@hobofan hobofan commented Nov 4, 2023

CLOSES #117

Adjustments to metadata/Github repo link:

  • Adds a link to the GitHub repository to sidebar
  • The label for the hompage link is now just "Homepage" (better consistency across pages)
  • Add icons for both repo and homepage links
  • If the homepage and repository links are redundant (very often the case, as the homepage field is required metdata and often set to the repository page), the homepage link is omitted, and only the repo link is displayed

Also includes some smaller styling adjustments/visual bugs:

  • For phone screen sizes the metadata section is moved below the other content (not as a sidebar anymore)
  • Reduced the top margin of the metadata sidebar so that it is consistent with the other content
  • Better wrapping for "long" maintainer names
  • Sidebar is less squished for modules with short name (e.g. rules_go)
Example screenshots

Old (rules_aspect_js): image

New (rules_aspect_js): image

Old (rules_go):
image

New (rules_go):
image

@hobofan hobofan requested a review from alexeagle November 4, 2023 13:50
@hobofan hobofan self-assigned this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to repositories to sidebar of module page
1 participant