Issue with package version sorting when .bcr.* versions are involved
#142
Comments
|
Thanks for bringing this up! At the core this sounds like what has already been discussed in #54 (and #22). The efforts on that front have become a bit stale on my front, but I'll try to push it forward soon (it's essentially fixed on a technical level, but need to go through some organizational motions so that I don't end up as the single point of failure here). |
|
Why does the BCR UI even re-sort the versions? Wouldn't it be enough to go with the order of the version list in metadata.json? (#54 (comment)) |
This was referenced Jul 23, 2024
Wyverald
added a commit
that referenced
this issue
Jul 24, 2024
Got bored and wanted to explore Typescript. Tested on https://typescriptlang.org/play: > console.log(sortVersions(['1.2.3', '1.2.3-d', '1.2.3.bcr.1', '1.2.3rc3', '1', 'k'])) ["k", "1.2.3rc3", "1.2.3.bcr.1", "1.2.3", "1.2.3-d", "1"] Addresses #54. Fixes #142.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed that for the zstd and the google test packages there are
.bcr.1packages that even though are more recent than the latest version and they presumably fix issues with the bazel central registry patching, they are not shown up as the latest versions nor appear in the correct order in the all versions list.This has caused a problem specifically with zstd, as the
.bcr.1version contains this fix without which we could not use that dependency, and it was not at all clear from the start we needed to get that version.The text was updated successfully, but these errors were encountered: