Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement version sorting according to specification #22

Closed
hobofan opened this issue Oct 20, 2022 · 1 comment
Closed

Implement version sorting according to specification #22

hobofan opened this issue Oct 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@hobofan
Copy link
Member

hobofan commented Oct 20, 2022

An initial simple SemVer sorting was added with #21.

To have the "proper" sorting that is more robust, the sorting should need to be implemented in JS according to the spec as pointed out in the comment: #21 (comment)
@hobofan hobofan added the enhancement New feature or request label Oct 20, 2022
@hobofan
Copy link
Member Author

hobofan commented Nov 4, 2023

Over time #54 has evolved to encompas this, and landing bazel-contrib/SIG-rules-authors#83 would also resolve this, so I think this issue is kind of redundant.

@hobofan hobofan closed this as completed Nov 4, 2023
@hobofan hobofan mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hobofan