Hotfix version parsing breaking build by ignoring non-semver #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Feb 3, 2023
|
@hobofan I think this got the sorting backwards. https://registry.bazel.build/modules/rules_python is suggesting to copy-paste a snippet that gives 0.4.0 while the latest is 0.18.1 |
|
@alexeagle Ah damn, you are right. When going to the non-versioned page it also picks the oldest version as the latest version. I tried to straighten out the sorting, but looks like I missed that part. Will open a PR ASAP. |
|
Ping on this @hobofan |
|
This came up today in the "bzlmod" channel of the "Bazel" Slack workspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #54
compare-versionsto latest version