Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template URL to a stable URL #126

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Update template URL to a stable URL #126

merged 2 commits into from
Jan 9, 2024

Conversation

illicitonion
Copy link
Contributor

BCR appears to enforce this now

@illicitonion
Update template URL to a stable URL
e75f15b 
BCR appears to enforce this now
kormide
kormide requested changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also update the reference here?

@illicitonion
Copy link
Contributor Author

Sorry @kormide I don't think I see a reference in that file that isn't already updated - can you quote the text you're looking to update? Thanks!

@kormide
Copy link
Collaborator

kormide commented Jan 9, 2024

here

This line: https://github.com/bazel-contrib/publish-to-bcr/blob/main/templates/README.md?plain=1#L80

@illicitonion
Copy link
Contributor Author

I think that's the line currently edited in this PR?

@kormide
Copy link
Collaborator

kormide commented Jan 9, 2024

Doh, I thought that was the template file 😅 . Could you update the template file at templates/.bcr/source.template.json?

@illicitonion
Copy link
Contributor Author

😂 Done! Thanks!

@kormide kormide merged commit e3015e7 into bazel-contrib:main Jan 9, 2024
2 checks passed
@illicitonion illicitonion deleted the template-stable-url branch January 9, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@cgrindel cgrindel cgrindel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illicitonion @kormide @cgrindel