ci: don't run e2es on PRs from forks #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
approved these changes
Jan 8, 2024
|
If this ends up being the workflow to allow CI runs from forks, we may want to create a markdown doc that documents this and any other interesting workflows (e.g. release). |
kormide
force-pushed
the
e2e-on-prs
branch
2 times, most recently
from
958a483 to
84a875c
Compare
|
I changed my mind on this. According to this article there are still some security risks associated with the I'm just going to disable e2e tests on PRs from forks, and they can run on the push event after they are merged. |
kormide
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2es fail on pull requests from a fork because GitHub Actions doesn't allow access to secrets on the
pull_requesttrigger.pull_request_targetis supposed to allow this. I added the labelrun e2eto tag PRs to allow e2es to be run, the assumption being that we carefully look through the changes before tagging. In addition, outside contributions must be approved.