fix: run e2e tests on pushes to main #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
commented
Jan 9, 2024
Comment on lines
-47
to
-58
| # Join CI jobs into a single status so that only one status needs to be | ||
| # marked as required under branch protection rules. | ||
| all_ci_tests: | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - test | ||
| - e2e | ||
| if: ${{ always() }} | ||
| steps: | ||
| - uses: cgrindel/gha_join_jobs@v1 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I had to remove this because for PRs from forks where we skip e2es, the joined check will fail when one of the inputs is skipped.
cgrindel
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.