Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run e2e tests on pushes to main #128

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: run e2e tests on pushes to main #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
# Don't run e2es on PRs from forks as it requires access to secrets
# when using `pull_request`.
# See https://securitylab.github.com/research/github-actions-preventing-pwn-requests
if: ${{ github.event.pull_request.head.repo.full_name == 'bazel-contrib/publish-to-bcr' }}
if: ${{ github.event_name == 'push' || github.event.pull_request.head.repo.full_name == 'bazel-contrib/publish-to-bcr' }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -43,16 +43,3 @@ jobs:
version: ">= 363.0.0"
- run: yarn install --frozen-lockfile
- run: yarn e2e

# Join CI jobs into a single status so that only one status needs to be
# marked as required under branch protection rules.
all_ci_tests:
runs-on: ubuntu-latest
needs:
- test
- e2e
if: ${{ always() }}
steps:
- uses: cgrindel/gha_join_jobs@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
Comment on lines -47 to -58
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove this because for PRs from forks where we skip e2es, the joined check will fail when one of the inputs is skipped.