Cope with missing version attribute on module
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
force-pushed
the
allow-missing-module-version
branch
from
a430919 to
c98cae5
Compare
fmeum
reviewed
Jan 26, 2024
|
Thanks for the fix! I'd like to get a new fixture/e2e in to test this, as well as unit tests for module-file.ts. Let me know if you want to do that, else I can take it over from here. |
kormide
force-pushed
the
allow-missing-module-version
branch
from
f245c8a to
037f706
Compare
|
Pushed some small fixes and additional tests. |
kormide
approved these changes
Jan 30, 2024
kormide
force-pushed
the
allow-missing-module-version
branch
from
037f706 to
0fc0c67
Compare
|
I want to add another test. I'll squash and merge when it's ready. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
The
versionattribute is technically required for non-root modules, but it should be ok for repos to not have it if they use the publish-to-bcr-bot to automatically patch it in when publishing to BCR.