feat: correctly sort bazel module versions #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
module-version
branch
from
7650d0f to
3296eae
Compare
kormide
changed the title
kormide
force-pushed
the
module-version
branch
2 times, most recently
from
3c17102 to
0fe4743
Compare
fmeum
reviewed
Feb 6, 2024
fmeum
approved these changes
Feb 6, 2024
|
The code looks good. However, I wanted to point out that a TypeScript library for bzlmod verions. Do you think it makes sense to leverage the library? |
Nice, I had no idea this existed. I'll use that instead. |
It looks like this hasn't actually been published to npm, yet. @hobofan Are there any plans to do so? |
kormide
force-pushed
the
module-version
branch
from
0fe4743 to
2b15de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort module versions in the official order.
See bazelbuild/bazel-central-registry#1431 (comment).