Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hermeticity for clang #159

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Improve hermeticity for clang #159

merged 2 commits into from
Sep 6, 2023

Conversation

cloudhan
Copy link
Collaborator

@cloudhan cloudhan commented Sep 6, 2023

No description provided.

@cloudhan
Copy link
Collaborator Author

cloudhan commented Sep 6, 2023 •
edited
Loading

EDIT: This was canceled due to it use workflow file from main branch. Fallback to use manual workflow_dispatch to bring in the flags change.

/test

jsharpe
jsharpe approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudhan cloudhan merged commit a7bce91 into main Sep 6, 2023
18 of 19 checks passed
@cloudhan cloudhan deleted the cloudhan/hermetic-clang branch September 6, 2023 15:55
@rnburn rnburn mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharpe jsharpe jsharpe approved these changes

@ryanleary ryanleary Awaiting requested review from ryanleary ryanleary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudhan @jsharpe