eliminate cpu architecture constraint for clang #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmellosanjay
requested review from
cloudhan,
jsharpe and
ryanleary
as code owners
cloudhan
approved these changes
Jan 3, 2024
anakinxc
referenced
this pull request
in secretflow/spu
Aug 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_cuda](https://togithub.com/bazel-contrib/rules_cuda) | http_archive | patch | `v0.2.1` -> `v0.2.2` | --- ### Release Notes <details> <summary>bazel-contrib/rules_cuda (rules_cuda)</summary> ### [`v0.2.2`](https://togithub.com/bazel-contrib/rules_cuda/releases/tag/v0.2.2) [Compare Source](https://togithub.com/bazel-contrib/rules_cuda/compare/v0.2.1...v0.2.2) #### `WORKSPACE` code ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_cuda", sha256 = "b066750579f33e93e9dc55b8ee2067b525d863c1ddcf09b47a6332c39f0701fb", strip_prefix = "rules_cuda-v0.2.2", urls = ["https://github.com/bazel-contrib/rules_cuda/releases/download/v0.2.2/rules_cuda-v0.2.2.tar.gz"], ) load("@​rules_cuda//cuda:repositories.bzl", "register_detected_cuda_toolchains", "rules_cuda_dependencies") rules_cuda_dependencies() register_detected_cuda_toolchains() ``` #### What's Changed - Filter attrs properly for cuda_test by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/180](https://togithub.com/bazel-contrib/rules_cuda/pull/180) - Fix cuda_test by [@​hofbi](https://togithub.com/hofbi) in [https://github.com/bazel-contrib/rules_cuda/pull/181](https://togithub.com/bazel-contrib/rules_cuda/pull/181) - Add v0.2.1 to docs by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/184](https://togithub.com/bazel-contrib/rules_cuda/pull/184) - Pass through `--sysroot` to host compiler by [@​lalten](https://togithub.com/lalten) in [https://github.com/bazel-contrib/rules_cuda/pull/185](https://togithub.com/bazel-contrib/rules_cuda/pull/185) - Add cuda_binary macro by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/186](https://togithub.com/bazel-contrib/rules_cuda/pull/186) - Move non glob files out of glob by [@​hofbi](https://togithub.com/hofbi) in [https://github.com/bazel-contrib/rules_cuda/pull/192](https://togithub.com/bazel-contrib/rules_cuda/pull/192) - Disallow autoupdate nccl by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/193](https://togithub.com/bazel-contrib/rules_cuda/pull/193) - eliminate cpu architecture constraint for clang by [@​dmellosanjay](https://togithub.com/dmellosanjay) in [https://github.com/bazel-contrib/rules_cuda/pull/208](https://togithub.com/bazel-contrib/rules_cuda/pull/208) - Check nvcc version before adding `--dopt on` flags by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/212](https://togithub.com/bazel-contrib/rules_cuda/pull/212) - Add alwayslink to cuda_binary and cuda_test macros by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/210](https://togithub.com/bazel-contrib/rules_cuda/pull/210) - Add additional tests for LTS releases by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/215](https://togithub.com/bazel-contrib/rules_cuda/pull/215) - Fix cquery-ing with cuda targets by [@​mvukov](https://togithub.com/mvukov) in [https://github.com/bazel-contrib/rules_cuda/pull/209](https://togithub.com/bazel-contrib/rules_cuda/pull/209) - Propose new solution for know issue (nvcc filesystem race condition) by [@​hofbi](https://togithub.com/hofbi) in [https://github.com/bazel-contrib/rules_cuda/pull/216](https://togithub.com/bazel-contrib/rules_cuda/pull/216) - Fix a typo in `if_cuda` doc by [@​rygx](https://togithub.com/rygx) in [https://github.com/bazel-contrib/rules_cuda/pull/222](https://togithub.com/bazel-contrib/rules_cuda/pull/222) - Ignore MODULE.bazel.lock file by [@​rygx](https://togithub.com/rygx) in [https://github.com/bazel-contrib/rules_cuda/pull/224](https://togithub.com/bazel-contrib/rules_cuda/pull/224) - ci: avoid nvcc /tmp race condition by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/232](https://togithub.com/bazel-contrib/rules_cuda/pull/232) - ci: disable doc test workflow cache to avoid excessive space wasting by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/231](https://togithub.com/bazel-contrib/rules_cuda/pull/231) - feat: Add features for compiling with -arch=all or -arch=all-major by [@​jsharpe](https://togithub.com/jsharpe) in [https://github.com/bazel-contrib/rules_cuda/pull/245](https://togithub.com/bazel-contrib/rules_cuda/pull/245) - Fix spelling by [@​Vertexwahn](https://togithub.com/Vertexwahn) in [https://github.com/bazel-contrib/rules_cuda/pull/250](https://togithub.com/bazel-contrib/rules_cuda/pull/250) - Change example rules_cuda version by [@​Vertexwahn](https://togithub.com/Vertexwahn) in [https://github.com/bazel-contrib/rules_cuda/pull/249](https://togithub.com/bazel-contrib/rules_cuda/pull/249) - Document how to use rules_cuda with Bzlmod by [@​Vertexwahn](https://togithub.com/Vertexwahn) in [https://github.com/bazel-contrib/rules_cuda/pull/252](https://togithub.com/bazel-contrib/rules_cuda/pull/252) - Do not assume libcupti.so location by [@​tyb0807](https://togithub.com/tyb0807) in [https://github.com/bazel-contrib/rules_cuda/pull/253](https://togithub.com/bazel-contrib/rules_cuda/pull/253) - ci: use absolute path for XDG_CACHE_HOME as github actions and bazel doesn't resolve `~` automatically by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/260](https://togithub.com/bazel-contrib/rules_cuda/pull/260) - ci: cover major bazel releases in utilities tests by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/262](https://togithub.com/bazel-contrib/rules_cuda/pull/262) - test: workaround label resolving with bzlmod by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/263](https://togithub.com/bazel-contrib/rules_cuda/pull/263) - fix(bzlmod): allow both root module and our module to call cuda.local_toolchain by [@​cloudhan](https://togithub.com/cloudhan) in [https://github.com/bazel-contrib/rules_cuda/pull/264](https://togithub.com/bazel-contrib/rules_cuda/pull/264) #### New Contributors - [@​dmellosanjay](https://togithub.com/dmellosanjay) made their first contribution in [https://github.com/bazel-contrib/rules_cuda/pull/208](https://togithub.com/bazel-contrib/rules_cuda/pull/208) - [@​mvukov](https://togithub.com/mvukov) made their first contribution in [https://github.com/bazel-contrib/rules_cuda/pull/209](https://togithub.com/bazel-contrib/rules_cuda/pull/209) - [@​rygx](https://togithub.com/rygx) made their first contribution in [https://github.com/bazel-contrib/rules_cuda/pull/222](https://togithub.com/bazel-contrib/rules_cuda/pull/222) - [@​Vertexwahn](https://togithub.com/Vertexwahn) made their first contribution in [https://github.com/bazel-contrib/rules_cuda/pull/250](https://togithub.com/bazel-contrib/rules_cuda/pull/250) - [@​tyb0807](https://togithub.com/tyb0807) made their first contribution in [https://github.com/bazel-contrib/rules_cuda/pull/253](https://togithub.com/bazel-contrib/rules_cuda/pull/253) **Full Changelog**: bazel-contrib/rules_cuda@v0.2.1...v0.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/secretflow/spu). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building with clang on aarch64 machines. Same as how #8 did it for nvcc.