New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tests for LTS releases #215

Merged

cloudhan merged 5 commits into main from cloudhan/lts

Jan 16, 2024

Collaborator

cloudhan commented Jan 16, 2024

No description provided.

Base automatically changed from cloudhan/v7 to main

January 16, 2024 12:57

cloudhan added 3 commits

January 16, 2024 22:02


          ci: add missing tests for old LTS releases

9697b9d


          test: remove add_prefix to fix tests for bazel 5

81067dc

It was added in 6.0 and does not work for bazel 5


          chore: remove bzlmod config

3e98d40

cloudhan force-pushed the cloudhan/lts branch from 04cdc6f to 2c9a439 Compare

January 16, 2024 14:03


          ci: skip --experimental_enable_bzlmod case for Bazel 5

2061bee

cloudhan force-pushed the cloudhan/lts branch from 2c9a439 to 2061bee Compare

January 16, 2024 14:04


          ci: fix env setup for windows

2c2cbf8

cloudhan marked this pull request as ready for review

January 16, 2024 14:35

cloudhan requested review from jsharpe and ryanleary as code owners

January 16, 2024 14:35

jsharpe approved these changes

View reviewed changes

.github/workflows/build-tests.yaml

+                    - run: bazelisk build @rules_cuda_examples//rdc:all
+                    - run: bazelisk build @rules_cuda_examples//if_cuda:main
+                    - run: bazelisk build @rules_cuda_examples//if_cuda:main --enable_cuda=False
+                    # bzlmod is not covered, our separate @rules_cuda_examples repo setup doesn't play well with it

Member

jsharpe Jan 16, 2024

I think this is perfectly valid - bazel 5 really didn't support all the required bzlmod features needed for a functional bzlmod setup.

Collaborator Author

cloudhan Jan 16, 2024 •

edited

Loading

Right, it is perfectly valid as we have been exercising the practice for very long time without problem.

It is purely caused by the experimental feature did not correctly handle the repo setup at that time.

Collaborator Author

cloudhan commented Jan 16, 2024

/test

github-actions bot commented Jan 16, 2024

Integration Build: succeeded ✅
https://github.com/bazel-contrib/rules_cuda/actions/runs/7543478251

cloudhan merged commit 1e5fd43 into main

15 checks passed

cloudhan deleted the cloudhan/lts branch

January 16, 2024 15:35

anakinxc referenced this pull request in secretflow/spu


          chore(deps): update dependency rules_cuda to v0.2.2 (#809)

bb8d336

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rules_cuda](https://togithub.com/bazel-contrib/rules_cuda) |
http_archive | patch | `v0.2.1` -> `v0.2.2` |

---

### Release Notes

<details>
<summary>bazel-contrib/rules_cuda (rules_cuda)</summary>

###
[`v0.2.2`](https://togithub.com/bazel-contrib/rules_cuda/releases/tag/v0.2.2)

[Compare
Source](https://togithub.com/bazel-contrib/rules_cuda/compare/v0.2.1...v0.2.2)

#### `WORKSPACE` code

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_cuda",
    sha256 = "b066750579f33e93e9dc55b8ee2067b525d863c1ddcf09b47a6332c39f0701fb",
    strip_prefix = "rules_cuda-v0.2.2",
    urls = ["https://github.com/bazel-contrib/rules_cuda/releases/download/v0.2.2/rules_cuda-v0.2.2.tar.gz"],
)

load("@&#8203;rules_cuda//cuda:repositories.bzl", "register_detected_cuda_toolchains", "rules_cuda_dependencies")
rules_cuda_dependencies()
register_detected_cuda_toolchains()
```

#### What's Changed

- Filter attrs properly for cuda_test by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/180](https://togithub.com/bazel-contrib/rules_cuda/pull/180)
- Fix cuda_test by [@&#8203;hofbi](https://togithub.com/hofbi) in
[https://github.com/bazel-contrib/rules_cuda/pull/181](https://togithub.com/bazel-contrib/rules_cuda/pull/181)
- Add v0.2.1 to docs by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/184](https://togithub.com/bazel-contrib/rules_cuda/pull/184)
- Pass through `--sysroot` to host compiler by
[@&#8203;lalten](https://togithub.com/lalten) in
[https://github.com/bazel-contrib/rules_cuda/pull/185](https://togithub.com/bazel-contrib/rules_cuda/pull/185)
- Add cuda_binary macro by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/186](https://togithub.com/bazel-contrib/rules_cuda/pull/186)
- Move non glob files out of glob by
[@&#8203;hofbi](https://togithub.com/hofbi) in
[https://github.com/bazel-contrib/rules_cuda/pull/192](https://togithub.com/bazel-contrib/rules_cuda/pull/192)
- Disallow autoupdate nccl by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/193](https://togithub.com/bazel-contrib/rules_cuda/pull/193)
- eliminate cpu architecture constraint for clang by
[@&#8203;dmellosanjay](https://togithub.com/dmellosanjay) in
[https://github.com/bazel-contrib/rules_cuda/pull/208](https://togithub.com/bazel-contrib/rules_cuda/pull/208)
- Check nvcc version before adding `--dopt on` flags by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/212](https://togithub.com/bazel-contrib/rules_cuda/pull/212)
- Add alwayslink to cuda_binary and cuda_test macros by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/210](https://togithub.com/bazel-contrib/rules_cuda/pull/210)
- Add additional tests for LTS releases by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/215](https://togithub.com/bazel-contrib/rules_cuda/pull/215)
- Fix cquery-ing with cuda targets by
[@&#8203;mvukov](https://togithub.com/mvukov) in
[https://github.com/bazel-contrib/rules_cuda/pull/209](https://togithub.com/bazel-contrib/rules_cuda/pull/209)
- Propose new solution for know issue (nvcc filesystem race condition)
by [@&#8203;hofbi](https://togithub.com/hofbi) in
[https://github.com/bazel-contrib/rules_cuda/pull/216](https://togithub.com/bazel-contrib/rules_cuda/pull/216)
- Fix a typo in `if_cuda` doc by
[@&#8203;rygx](https://togithub.com/rygx) in
[https://github.com/bazel-contrib/rules_cuda/pull/222](https://togithub.com/bazel-contrib/rules_cuda/pull/222)
- Ignore MODULE.bazel.lock file by
[@&#8203;rygx](https://togithub.com/rygx) in
[https://github.com/bazel-contrib/rules_cuda/pull/224](https://togithub.com/bazel-contrib/rules_cuda/pull/224)
- ci: avoid nvcc /tmp race condition by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/232](https://togithub.com/bazel-contrib/rules_cuda/pull/232)
- ci: disable doc test workflow cache to avoid excessive space wasting
by [@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/231](https://togithub.com/bazel-contrib/rules_cuda/pull/231)
- feat: Add features for compiling with -arch=all or -arch=all-major by
[@&#8203;jsharpe](https://togithub.com/jsharpe) in
[https://github.com/bazel-contrib/rules_cuda/pull/245](https://togithub.com/bazel-contrib/rules_cuda/pull/245)
- Fix spelling by [@&#8203;Vertexwahn](https://togithub.com/Vertexwahn)
in
[https://github.com/bazel-contrib/rules_cuda/pull/250](https://togithub.com/bazel-contrib/rules_cuda/pull/250)
- Change example rules_cuda version by
[@&#8203;Vertexwahn](https://togithub.com/Vertexwahn) in
[https://github.com/bazel-contrib/rules_cuda/pull/249](https://togithub.com/bazel-contrib/rules_cuda/pull/249)
- Document how to use rules_cuda with Bzlmod by
[@&#8203;Vertexwahn](https://togithub.com/Vertexwahn) in
[https://github.com/bazel-contrib/rules_cuda/pull/252](https://togithub.com/bazel-contrib/rules_cuda/pull/252)
- Do not assume libcupti.so location by
[@&#8203;tyb0807](https://togithub.com/tyb0807) in
[https://github.com/bazel-contrib/rules_cuda/pull/253](https://togithub.com/bazel-contrib/rules_cuda/pull/253)
- ci: use absolute path for XDG_CACHE_HOME as github actions and bazel
doesn't resolve `~` automatically by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/260](https://togithub.com/bazel-contrib/rules_cuda/pull/260)
- ci: cover major bazel releases in utilities tests by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/262](https://togithub.com/bazel-contrib/rules_cuda/pull/262)
- test: workaround label resolving with bzlmod by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/263](https://togithub.com/bazel-contrib/rules_cuda/pull/263)
- fix(bzlmod): allow both root module and our module to call
cuda.local_toolchain by
[@&#8203;cloudhan](https://togithub.com/cloudhan) in
[https://github.com/bazel-contrib/rules_cuda/pull/264](https://togithub.com/bazel-contrib/rules_cuda/pull/264)

#### New Contributors

- [@&#8203;dmellosanjay](https://togithub.com/dmellosanjay) made their
first contribution in
[https://github.com/bazel-contrib/rules_cuda/pull/208](https://togithub.com/bazel-contrib/rules_cuda/pull/208)
- [@&#8203;mvukov](https://togithub.com/mvukov) made their first
contribution in
[https://github.com/bazel-contrib/rules_cuda/pull/209](https://togithub.com/bazel-contrib/rules_cuda/pull/209)
- [@&#8203;rygx](https://togithub.com/rygx) made their first
contribution in
[https://github.com/bazel-contrib/rules_cuda/pull/222](https://togithub.com/bazel-contrib/rules_cuda/pull/222)
- [@&#8203;Vertexwahn](https://togithub.com/Vertexwahn) made their first
contribution in
[https://github.com/bazel-contrib/rules_cuda/pull/250](https://togithub.com/bazel-contrib/rules_cuda/pull/250)
- [@&#8203;tyb0807](https://togithub.com/tyb0807) made their first
contribution in
[https://github.com/bazel-contrib/rules_cuda/pull/253](https://togithub.com/bazel-contrib/rules_cuda/pull/253)

**Full Changelog**:
bazel-contrib/rules_cuda@v0.2.1...v0.2.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/secretflow/spu).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet