Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bcr): add basic presubmit yaml #273

Merged
merged 2 commits into from
Sep 7, 2024
Merged

fix(bcr): add basic presubmit yaml #273

merged 2 commits into from
Sep 7, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Sep 6, 2024

@wep21
fix(bcr): add basic presubmit yaml
6bfef63 
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@cloudhan
Copy link
Collaborator

cloudhan commented Sep 7, 2024

@wep21 Thanks for the contribution. Based on the BRC PR I think we can just assume it works and a new tag will pass thoes CI and merge as is?

jsharpe
jsharpe approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this should automatically flow through to the BCR next time we release. Thanks for also updating the source repo as well as the BCR!

@jsharpe jsharpe merged commit 538e34e into bazel-contrib:main Sep 7, 2024
16 checks passed
@wep21 wep21 deleted the add-basic-presubmit-yaml branch September 7, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharpe jsharpe jsharpe approved these changes

@cloudhan cloudhan Awaiting requested review from cloudhan cloudhan is a code owner

@ryanleary ryanleary Awaiting requested review from ryanleary ryanleary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wep21 @cloudhan @jsharpe