ci: update libtinfo5 installation for Ubuntu 24.04
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrbutani
force-pushed
the
fix/ubuntu-ci
branch
5 times, most recently
from
9ff9dec
to
4510a48
Compare
As per actions/runner-images#10636 `ubuntu-latest` is now Ubuntu 24.04 instead of 22.04 which [does not] have `libtinfo5` in the default PPAs [does not]: https://packages.ubuntu.com/search?keywords=libtinfo Unfortunately all of the LLVM binary releases still for Ubuntu still target 18.04 and contain binaries linked against `libtinfo5` — bumping the version of LLVM we use in our tests' toolchains will not solve this problem. Pinning CI to use Ubuntu 22.04 is an option; however this PR installs `libtinfo5` on the Ubuntu 24.04 runners manually instead.
rrbutani
force-pushed
the
fix/ubuntu-ci
branch
from
4510a48
to
8f139d4
Compare
|
if you want to not install it we just need to use the 19.x train of llvm, which no longer has a dep on this lib |
Good catch; forgot about that change. I think it makes sense for us to still test some of the older LLVM toolchain versions in our test suite but I don't feel strongly about this. I'm going to leave this change as is for now to get CI unbroken but feel free to remove this workaround + bump LLVM in the tests in a follow up. |
|
++ on testing old stuff, just figured that might be easier, but looks like you already got something working so nvm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per actions/runner-images#10636
ubuntu-latestis now Ubuntu 24.04 instead of 22.04 which does not havelibtinfo5in the default PPAs.Unfortunately all of the LLVM binary releases for Ubuntu still target 18.04
and contain binaries linked against(see below).libtinfo5— bumping the version of LLVM we use in our tests' toolchains will not solve this problemPinning CI to use Ubuntu 22.04 is an option; however this PR installs
libtinfo5on the Ubuntu 24.04 runners manually instead.