Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support negative globs for test_sources section in project file #6642

Open
sfc-gh-mgalindo opened this issue Aug 15, 2024 · 1 comment
Open
Labels
awaiting-maintainer Awaiting review from Bazel team on issues P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin type: feature request

Comments

@sfc-gh-mgalindo
Copy link
Contributor

Description of the feature request:

There are cases when valid utility classes are defined under a test file declared under the test_sources section. It would be nice to be able to do something like

test_sources:
  SomeDir/src/test/**
  -SomeDir/src/test/specific/java/file.jva

This comes after I run in some issues with classes declared under a test directory in #6641. The issue has a pretty long winded explanation thats not worth reading but it the tl;dr is I didn't notice a source being under src/test instead of src/main and was not being indexed and that send me down a rabbit hole to find an issue with indexing that wasn't really an issue. I understand having non test classes under src/test is a pretty big code smell, but I'm working in a large codebase whith a bunch of legacy stuff that I dont control.

Which category does this issue belong to?

Intellij

What underlying problem are you trying to solve with this feature?

No response

What operating system, Intellij IDE and programming languages are you using? Please provide specific versions.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@sfc-gh-mgalindo sfc-gh-mgalindo added awaiting-maintainer Awaiting review from Bazel team on issues type: feature request labels Aug 15, 2024
@github-actions github-actions bot added the product: IntelliJ IntelliJ plugin label Aug 15, 2024
@tpasternak tpasternak added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Aug 16, 2024
@sfc-gh-mgalindo
Copy link
Contributor Author

Looks like this is a bit more complicated to implement that originally thought. Sources are tracked at the directory level and not file level, so excluding individual files seems like a non starter here

@mai93 mai93 removed their assignment Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants