Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove hardcoded rule kinds requirement for source-code generators #6429

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ghorak-happening
Copy link

@ghorak-happening ghorak-happening commented May 15, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6428

Description of this change

Removing hardcoded proto rule name to enable other Go code generators

Copy link

google-cla bot commented May 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ghorak-happening ghorak-happening marked this pull request as ready for review September 26, 2024 08:07
@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Sep 26, 2024
@ghorak-happening ghorak-happening marked this pull request as draft September 26, 2024 08:09
@sgowroji
Copy link
Member

Hi @ghorak-happening, CLA is not signed for below mentioned email id. Can you do it to move the CLA passed for this PR.

295b770 Author: @ghorak-happening <gor******ak​@happening.xyz>

@sgowroji
Copy link
Member

Hi @ghorak-happening, Can you please go through the complete steps mentioned here https://github.com/bazelbuild/intellij/pull/6429/checks?check_run_id=30712727372

@sgowroji sgowroji added more-data-needed Awaiting response from issue author product: GoLand GoLand plugin and removed awaiting-review Awaiting review from Bazel team on PRs labels Sep 26, 2024
@agluszak
Copy link
Collaborator

@ghorak-happening why is this a draft?

@ghorak-happening
Copy link
Author

Hi,

@sgowroji, I went through the proces several times. I am required to sign corporate CLA, not personal CLA (my colleague Mislav is discussing this over Slack with you)

@agluszak I've left the PR in draft until the CLA issue is solved, if you'd like, I can remove it from draft.

@ghorak-happening ghorak-happening marked this pull request as ready for review October 8, 2024 06:15
@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Oct 8, 2024
@ghorak-happening
Copy link
Author

Hi,

I've successfully completed the CLA process and published this PR out of draft. Please advise on the next steps.

cc @sgowroji @agluszak

@sgowroji sgowroji removed the more-data-needed Awaiting response from issue author label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Awaiting review from Bazel team on PRs product: GoLand GoLand plugin
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants