[#6664]: Invoke blaze mod correctly
#6729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
mtoader
force-pushed
the
mtoader/invoke-blaze-mod-correctly
branch
from
2c28e4c
to
fb3aeef
Compare
agluszak
requested changes
Sep 5, 2024
| @@ -38,6 +38,9 @@ | |||
|
|
|||
| public class BlazeModRunnerImpl extends BlazeModRunner { | |||
|
|
|||
| private static final String DUMP_REPO_MAPPING = "dump_repo_mapping"; | |||
| private static final String ROOT_WORKSPACE = ""; | |||
There was a problem hiding this comment.
previously it was "workspace", not an empty string
There was a problem hiding this comment.
I see the context there: #6664 (comment)
Could you summarize that in a code comment?
| @@ -83,6 +83,9 @@ public ListenableFuture<ExternalWorkspaceData> getExternalWorkspaceData( | |||
| return Futures.immediateFuture(ExternalWorkspaceData.EMPTY); | |||
| } | |||
|
|
|||
| // TODO: when 8.0.0 is released add this conditionally only when it's disabled inside `starLarkSemantics` | |||
There was a problem hiding this comment.
could you also explain the need for this flag in a comment?
mtoader
force-pushed
the
mtoader/invoke-blaze-mod-correctly
branch
from
fb3aeef
to
23e08ae
Compare
|
@agluszak updated comments and moved the flag patch to the execution place (to be near the comment) |
agluszak
reviewed
Sep 5, 2024
| * repository map we would invoke it like {@code bazel mod dump_repo_mapping ""}. | ||
| * <p /> | ||
| * Additionally the flag {@code --enable_workspace} needs to be off for this to work. The flag is default | ||
| * off in bazel 8.0.0 but it is on between 7.1.0 and 8.0.0. So we need to also pass this along in |
There was a problem hiding this comment.
is this flag supported by Bazel <7.1.0? If not, doesn't it break Bazel 6 and 5?
There was a problem hiding this comment.
This will not get called at all before 7.1.0 since the dump command itself didn't exist before.
agluszak
approved these changes
Sep 6, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Discussion thread for this change
Issue number: #6664
Description of this change
Invoke
blaze mod dump_repo_mappingcorrectly