[#6664,#505]: Enable External Workspace completions and tests - 5/n #6730
Conversation
Also add a CharFilter that enable:
* '@' to filter the lookup elements and not hide the lookup.
* '/' to autocomplete selected item
Other issues: bazelbuild#505
github-actions
bot
added
product: CLion
| endIndex = rawText.length() - 1; | ||
| endIndex = rawText.length() - quoteType.quoteString.length(); | ||
| } else { | ||
| endIndex += 2; |
There was a problem hiding this comment.
We still don't cover this scenario, however I'm not sure if we even should
Screen.Recording.2024-09-05.at.11.23.41.mov
There was a problem hiding this comment.
Yea. I don't think we should do that here.
|
|
||
| WorkspaceRoot workspaceRoot = WorkspaceHelper.getExternalWorkspace(myElement.getProject(), name); | ||
| if (workspaceRoot != null) { | ||
| return BuildReferenceManager.getInstance(myElement.getProject()).findBuildFile(workspaceRoot.directory()); |
There was a problem hiding this comment.
The behavior is a bit different as it points to a BUILD file, but it's out of scope of this PR
There was a problem hiding this comment.
Yea. This is slightly wrong, too, since it should point to either a WORKSPACE or a MODULE.xx file anyway. It's a net improvement though and is still helpful for the next step: to root completion of packagePaths from the containing folder
| return EMPTY_ARRAY; | ||
| @Nonnull | ||
| public BuildLookupElement[] getVariants() { | ||
| BlazeProjectData blazeProjectData = BlazeProjectDataManager.getInstance(myElement.getProject()).getBlazeProjectData(); |
There was a problem hiding this comment.
I'm a bit worried it could kill the UI in case of a large number of external repositories
There was a problem hiding this comment.
This should come from in-memory data though.
github-actions
bot
removed
the
awaiting-review
Checklist
Discussion thread for this change
Issue number: #6664, #505
Description of this change
Also add a CharFilter that enable:
* '@' to filter the lookup elements and not hide the lookup.
* '/' to autocomplete selected item