-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6664] Completion of FilePath and targets from external repositories #6742
Merged
mai93
merged 7 commits into
bazelbuild:master
from
mtoader:mtoader/file-and-target-completion-from-external
Sep 13, 2024
Merged
[#6664] Completion of FilePath and targets from external repositories #6742
mai93
merged 7 commits into
bazelbuild:master
from
mtoader:mtoader/file-and-target-completion-from-external
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
CLion plugin
product: IntelliJ
IntelliJ plugin
product: GoLand
GoLand plugin
awaiting-review
Awaiting review from Bazel team on PRs
labels
Sep 8, 2024
tpasternak
assigned agluszak, jastice and ujohnny and unassigned ujohnny, tpasternak and mai93
Sep 8, 2024
sorry for the delay, I'm mostly OOO this week |
agluszak
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should i ping someone to land this ? |
github-actions
bot
removed
the
awaiting-review
Awaiting review from Bazel team on PRs
label
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Discussion thread for this change
Issue number: #6664, #505
Description of this change
This hould be the last big PR closing those two issues. It adds external workspace prefixed path and rule completion. Semantics should be similar to the current completion semantics. Added tests for it and tweaked the test fixtures to help.