Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6664] Completion of FilePath and targets from external repositories #6742

Conversation

mtoader
Copy link
Contributor

@mtoader mtoader commented Sep 8, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change

Issue number: #6664, #505

Description of this change

This hould be the last big PR closing those two issues. It adds external workspace prefixed path and rule completion. Semantics should be similar to the current completion semantics. Added tests for it and tweaked the test fixtures to help.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 8, 2024
@tpasternak
Copy link
Collaborator

sorry for the delay, I'm mostly OOO this week

Copy link
Collaborator

@agluszak agluszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtoader
Copy link
Contributor Author

mtoader commented Sep 13, 2024

Should i ping someone to land this ?

@mai93 mai93 merged commit c3594cc into bazelbuild:master Sep 13, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants