Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for v2024.09.10 release #6745

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Update changelog for v2024.09.10 release #6745

merged 3 commits into from
Sep 10, 2024

Conversation

satyanandak
Copy link
Contributor

Please let me know of any important changes that you want to make visible by adding to the Change log.

Please let me know of any important changes that you want to make visible by adding to the Change log.
@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Sep 9, 2024
@tpasternak
Copy link
Collaborator

Hey, we are releasing external labels indexing and completions, thanks to @mtoader

@tpasternak
Copy link
Collaborator

We didn't have such a tradition, however this contribution is so great, I would consider giving credits, WDYT? @mai93

@mai93
Copy link
Collaborator

mai93 commented Sep 9, 2024

We didn't have such a tradition, however this contribution is so great, I would consider giving credits, WDYT? @mai93

I agree, feel free to propose a suggestion on the comment. Thanks @mtoader!

@tpasternak
Copy link
Collaborator

idk how about just (credits: )

@mtoader
Copy link
Contributor

mtoader commented Sep 9, 2024

That still doesn't work well without the bazel flag changing ~ to + (the one becoming default true in bazel 8). So it will be limited in exposure until i have the notification in place to have the users update said flag.

Also the more important bit is #6742 (since it enables completion past the @xxx// in these cases :) I would mention this issue after we land this and add the notification bubble since that will be a "proper" user experience.

@mai93
Copy link
Collaborator

mai93 commented Sep 10, 2024

thanks @mtoader for the clarification, @satyanandak can you remove the "Features" part before submitting?

@mai93 mai93 merged commit 03a2c8f into master Sep 10, 2024
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants