Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current_module_package_info macro #147

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Aug 1, 2024

This macro makes it easy for Bazel modules to declare a package_info without having to provide any information manually.

Work towards bazelbuild/bazel#23166

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Tests and examples for any new features.
  • Appropriate changes to README are included in PR

This macro makes it easy for Bazel modules to declare a `package_info` without having to provide any information manually.
@fmeum fmeum force-pushed the current-module-package-info branch from 28b5647 to 37390a8 Compare August 1, 2024 10:10
@fmeum fmeum marked this pull request as ready for review August 7, 2024 10:38
@fmeum fmeum requested a review from aiuto as a code owner August 7, 2024 10:38
@fmeum
Copy link
Contributor Author

fmeum commented Aug 7, 2024

@aiuto This is ready for review now that the Rules Authors SIG approved the purl spec: package-url/purl-spec#317

@fmeum
Copy link
Contributor Author

fmeum commented Aug 27, 2024

@aiuto Friendly ping

@fmeum
Copy link
Contributor Author

fmeum commented Sep 16, 2024

@aiuto @shs96c Friendly ping

Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response. I forgot to come back to this after I did the 1.0 release.

@aiuto aiuto merged commit 5b980ea into bazelbuild:main Sep 19, 2024
2 checks passed
@fmeum fmeum deleted the current-module-package-info branch September 19, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants