Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move next should respect the QuickLoop bounds #31

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

mint-dewit
Copy link
Collaborator

No description provided.

@mint-dewit mint-dewit requested a review from Julusian November 6, 2024 14:40
Copy link
Collaborator

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have some unit tests for selectNewPartWithOffsets if you feel up to writing some. Same for getPartsBetweenMarkers.
I know there aren't any for either thing already, so I don't mind if you dont

packages/job-worker/src/playout/moveNextPart.ts Outdated Show resolved Hide resolved
@mint-dewit mint-dewit force-pushed the feat/move-next-in-quickloop branch from 2c65a0b to f2c4fd7 Compare January 6, 2025 15:42
@mint-dewit mint-dewit merged commit df01158 into bbc-release52 Jan 7, 2025
62 checks passed
@mint-dewit mint-dewit deleted the feat/move-next-in-quickloop branch January 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants