Parsing fails on valid JS file: extra + parenthesized/parenStart

[bzz]

Discovered though #54 (comment)

Using latest bblfshd v2.11.6/client.v3/javasript driver v2.6.0 parsing of the valid 2.4 mb .js file fails.

Steps to reproduce

wget https://raw.githubusercontent.com/laravel/telescope/6f0a10ec586cfa1a22218b6778bf9c1572b97912/public/app.js
node --check app.js // check JS syntax
go install github.com/bblfsh/client-go/cmd/bblfsh-cli/...
bblfsh-cli ./app.js

Expected

Very long semantic UAST printed in YAML format.

Actual

couldn't parse public/app.js: transform failed: received 15 errors:
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenStart
	check: key "extra": field was not used: parenStart
	check: key "extra": field was not used: parenStart
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenthesized
	check: key "extra": field was not used: parenStart

As noted #54 (comment) actual order of the failing Transformations can vary.

[juanjux]

Context: this is because SDK 2.14.0 added new checks to the semantic checker for silently dropped fields.

[bzz]

npm install @babel/parser
NODE_OPTIONS=--max_old_space_size=12000 ./node_modules/.bin/parser app.js  > app-js.ast

JavaScript: 2.5Mb
Native AST: 357Mb

😱

[creachadair]

npm install @babel/parser
NODE_OPTIONS=--max_old_space_size=12000 ./node_modules/.bin/parser app.js  > app-js.ast

JavaScript: 2.5Mb
Native AST: 357Mb

😱

I'm not too surprised—though this is a more dramatic expansion than usual. Syntactic structure is expensive in general, and very much not linear in file size. 🙃

[bzz]

Syntactic structure is expensive in general, and very much not linear in file size. 🙃
Indeed!

Just for the sake of experiment:
JavaScript: 2.5Mb
Native AST in JSON: 357Mb
bblfsh .native in YAML: 504Mb

and so far SDK tests finish with PASS without producing UAST for this AST (only .native) regardless of the test timeout.

[bzz]

This issue though is fixed in #57