This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
encode() and a stub for the load() #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
creachadair
approved these changes
Jun 6, 2019
dennwc
reviewed
Jun 7, 2019
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
|
Thank you for prompt reviews! |
dennwc
approved these changes
Jun 11, 2019
creachadair
reviewed
Jun 11, 2019
| @@ -15,6 +15,8 @@ jobject asJvmBuffer(uast::Buffer buf) { | |||
| return env->NewDirectByteBuffer(buf.ptr, buf.size); | |||
| } | |||
|
|
|||
| const char *nativeContext = "nativeContext"; | |||
There was a problem hiding this comment.
Minor nit: Either const char * const nativeContext = "…" or const char nativeContext[] = "…" is preferable here—to ensure the pointer itself is also const (either works). constexpr char nativeContext[] = "…" will also work if we assume C++ ≥ 11.
There was a problem hiding this comment.
Yes, thank you, we do! Was thinking about constexpr as well - will replace as part of the next PR.
creachadair
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #83
Context.encode()implementation + testsNode.load()Actual load() implementation will be done in subsequent PRs.