You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
SDK currently defines UAST hash to be opaque: clients cannot recompute it and the hash might change between SDK versions. This presents challenges for persisting those hash values.
We may need to define a hash that is stable between versions and well-defined. It may be a good idea to add (stable) hashing support to the binary UAST serialization.
The text was updated successfully, but these errors were encountered:
To avoid the issue with persistent data, I think there are two possible solutions:
Keep it opaque, but fix an algorithm and promise not to change it, or
Include a marker in the data that can be used to version it.
To implement (2), for example, we could make the first byte of the hash an algorithm tag (either by clobbering the first byte of the hash value, or just extending the array by 1 byte).
I don't really see much point in changing the algorithm, since we want it as a fingerprint rather than for security purposes, but either approach could work.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
SDK currently defines UAST hash to be opaque: clients cannot recompute it and the hash might change between SDK versions. This presents challenges for persisting those hash values.
We may need to define a hash that is stable between versions and well-defined. It may be a good idea to add (stable) hashing support to the binary UAST serialization.
The text was updated successfully, but these errors were encountered: