Rename workflow folder and Fix the Dockerfile syntax #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x86taka
force-pushed
the
chore/github-workflows
branch
from
df7d530
to
a93edb3
Compare
fix: fix workflow
fix: lint errors.
x86taka
force-pushed
the
chore/github-workflows
branch
from
b3e3ec8
to
270d7a2
Compare
takehaya
requested changes
Jul 24, 2024
pkg/diameter/diameter.go
Outdated
| m.NewAVP(avp.SessionID, avp.Mbit, 0, datatype.UTF8String(sid)) | ||
| m.NewAVP(avp.OriginHost, avp.Mbit, 0, c.cfg.OriginHost) | ||
| m.NewAVP(avp.OriginRealm, avp.Mbit, 0, c.cfg.OriginRealm) | ||
| _, err = m.NewAVP(avp.SessionID, avp.Mbit, 0, datatype.UTF8String(sid)) |
There was a problem hiding this comment.
Adding if err != nil every time we increase the code for NewAVP reduces readability.
It would be great if you could simplify it like this.
for example.
type avpData struct {
code avp.Code
flag avp.Flag
vendor uint32
value datatype.Type
}
avps := []avpData{
{avp.SessionID, avp.Mbit, 0, datatype.UTF8String(sid)},
{avp.OriginHost, avp.Mbit, 0, c.cfg.OriginHost},
{avp.OriginRealm, avp.Mbit, 0, c.cfg.OriginRealm},
}
for _, avp := range avps {
if _, err := m.NewAVP(avp.code, avp.flag, avp.vendor, avp.value); err != nil {
return false, errors.WithMessagef(err, "NewAVP %v failed", avp.code) // fix format me
}
}| if options.DestinationHost == nil { | ||
| m.NewAVP(avp.DestinationHost, avp.Mbit, 0, meta.OriginHost) | ||
| _, err := m.NewAVP(avp.DestinationHost, avp.Mbit, 0, meta.OriginHost) |
| @@ -0,0 +1,59 @@ | |||
| run: | |||
| timeout: 15m | |||
| skip-files: | |||
There was a problem hiding this comment.
I think this was taken from another project. so plz do not include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Merge condition